From: Weiguo Li Date: Wed, 9 Feb 2022 07:39:34 +0000 (+0800) Subject: net/memif: remove pointer deference before null check X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=b6c0f464affcf0ec6fcf0a26e517692dc08244f4;p=dpdk.git net/memif: remove pointer deference before null check There are duplicates of assignment here, the one before null check may cause a null pointer deference, so remove the previous one. Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Cc: stable@dpdk.org Signed-off-by: Weiguo Li Reviewed-by: Ferruh Yigit --- diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c index 42f48a68a1..7886644412 100644 --- a/drivers/net/memif/memif_socket.c +++ b/drivers/net/memif/memif_socket.c @@ -402,11 +402,10 @@ memif_msg_enq_init(struct rte_eth_dev *dev) { struct pmd_internals *pmd = dev->data->dev_private; struct memif_msg_queue_elt *e = memif_msg_enq(pmd->cc); - memif_msg_init_t *i = &e->msg.init; + memif_msg_init_t *i; if (e == NULL) return -1; - i = &e->msg.init; e->msg.type = MEMIF_MSG_TYPE_INIT; i->version = MEMIF_VERSION;