From: Yipeng Wang Date: Fri, 28 Sep 2018 14:11:05 +0000 (-0700) Subject: test/hash: fix bucket size in perf test X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=b772a15eb84ce616114880a20ad6ad91bb8970fc;p=dpdk.git test/hash: fix bucket size in perf test The bucket size was changed from 4 to 8 but the corresponding perf test was not changed accordingly. In the test, the bucket size and number of buckets are used to map to the underneath rte_hash structure. They are used to test performance of two conditions: keys in primary buckets only and keys in both primary and secondary buckets. Although there is no functional issue with bucket size set to 4, it mismatches the underneath rte_hash structure, which may affect code readability and future extension. Fixes: 58017c98ed53 ("hash: add vectorized comparison") Cc: stable@dpdk.org Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson Reviewed-by: Honnappa Nagarahalli --- diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c index 33dcb9fcf6..fe116326df 100644 --- a/test/test/test_hash_perf.c +++ b/test/test/test_hash_perf.c @@ -20,7 +20,8 @@ #define MAX_ENTRIES (1 << 19) #define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */ #define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added, several times */ -#define BUCKET_SIZE 4 +/* BUCKET_SIZE should be same as RTE_HASH_BUCKET_ENTRIES in rte_hash library */ +#define BUCKET_SIZE 8 #define NUM_BUCKETS (MAX_ENTRIES / BUCKET_SIZE) #define MAX_KEYSIZE 64 #define NUM_KEYSIZES 10