From: Rosen Xu Date: Tue, 22 May 2018 10:26:18 +0000 (+0800) Subject: bus/ifpga: fix null pointer dereference in scan X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=bb5c82daa7d696dbac85b283a8bc82aa75e8ed96;p=dpdk.git bus/ifpga: fix null pointer dereference in scan Fix ifpga_scan_one() null pointer dereferences issue. Coverity issue: 279454 Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") Cc: stable@dpdk.org Signed-off-by: Rosen Xu --- diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c index db16173b7a..b324872eed 100644 --- a/drivers/bus/ifpga/ifpga_bus.c +++ b/drivers/bus/ifpga/ifpga_bus.c @@ -159,7 +159,8 @@ ifpga_scan_one(struct rte_rawdev *rawdev, goto end; strlcpy(afu_pr_conf.bs_path, path, sizeof(afu_pr_conf.bs_path)); - if (rawdev->dev_ops->firmware_load && + if (rawdev->dev_ops && + rawdev->dev_ops->firmware_load && rawdev->dev_ops->firmware_load(rawdev, &afu_pr_conf)){ IFPGA_BUS_ERR("firmware load error %d\n", ret);