From: Andy Moreton Date: Thu, 16 Nov 2017 08:04:03 +0000 (+0000) Subject: net/sfc/base: fix ignoring function return value X-Git-Tag: spdx-start~670 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=c14a991305f8077e06fe8c0087a24195397ca031;p=dpdk.git net/sfc/base: fix ignoring function return value fix PreFAST issue, add missing annotation that function return value should not be ignored. Fix alignment. Fixes: 19b64c6ac35f ("net/sfc/base: import libefx base") Cc: stable@dpdk.org Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h index 834eea0b67..ca0f945177 100644 --- a/drivers/net/sfc/base/efx.h +++ b/drivers/net/sfc/base/efx.h @@ -913,13 +913,13 @@ efx_phy_media_type_get( __in efx_nic_t *enp, __out efx_phy_media_type_t *typep); -extern efx_rc_t +extern __checkReturn efx_rc_t efx_phy_module_get_info( - __in efx_nic_t *enp, - __in uint8_t dev_addr, - __in uint8_t offset, - __in uint8_t len, - __out_bcount(len) uint8_t *data); + __in efx_nic_t *enp, + __in uint8_t dev_addr, + __in uint8_t offset, + __in uint8_t len, + __out_bcount(len) uint8_t *data); #if EFSYS_OPT_PHY_STATS diff --git a/drivers/net/sfc/base/efx_phy.c b/drivers/net/sfc/base/efx_phy.c index 752cd52e61..c81a91c944 100644 --- a/drivers/net/sfc/base/efx_phy.c +++ b/drivers/net/sfc/base/efx_phy.c @@ -296,7 +296,7 @@ efx_phy_media_type_get( *typep = epp->ep_fixed_port_type; } - __checkReturn efx_rc_t + __checkReturn efx_rc_t efx_phy_module_get_info( __in efx_nic_t *enp, __in uint8_t dev_addr,