From: Seth Howell Date: Fri, 11 Oct 2019 20:56:07 +0000 (-0700) Subject: bus/pci: remove useless link dependency on ethdev X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=c345c7d1acf43b4d30e1ecdd5a8cd3402234a6aa;p=dpdk.git bus/pci: remove useless link dependency on ethdev The makefile in drivers/bus/pci specified rte_ethdev as a dependency for the library. However there are no actual symbols from librte_ethdev used in librte_bus_pci. Including librte_ethdev as a dependency only becomes a problem in some niche cases like when attempting to build the rte_bus_pci library as a shared object without building the rte_ethdev library. I specifically ran into this when trying to build the DPDK included as an SPDK submodule on a FreeBSD machine. I figure that since there are no real dependencies between the two, we should enable building librte_bus_pci without librte_ethdev. Fixes: c752998b5e2e ("pci: introduce library and driver") Cc: stable@dpdk.org Signed-off-by: Seth Howell Acked-by: Gaetan Rivet --- diff --git a/drivers/bus/pci/Makefile b/drivers/bus/pci/Makefile index 68c1f3fde4..45d12427a1 100644 --- a/drivers/bus/pci/Makefile +++ b/drivers/bus/pci/Makefile @@ -25,7 +25,7 @@ CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common CFLAGS += -DALLOW_EXPERIMENTAL_API LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring -LDLIBS += -lrte_ethdev -lrte_pci -lrte_kvargs +LDLIBS += -lrte_pci -lrte_kvargs include $(RTE_SDK)/drivers/bus/pci/$(SYSTEM)/Makefile SRCS-$(CONFIG_RTE_LIBRTE_PCI_BUS) := $(addprefix $(SYSTEM)/,$(SRCS))