From: Bing Zhao Date: Wed, 29 Apr 2020 13:06:14 +0000 (+0800) Subject: net/mlx5: fix assert in modify converting X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=c8fa92f6c16691664a3f8e080233aa3480907497;p=dpdk.git net/mlx5: fix assert in modify converting The assertion was added incorrectly in converting the modify actions into the format of low layer driver. There is no mask specified in the rte_flow actions, and PMD driver will give a mask of all 1s to the field to be modified. For each field, the mask could not be zero. But for the whole header which contains this field, the masks of other fields could be zero. The assertion needs to be removed for debug mode. Fixes: 72a944dba163 ("net/mlx5: fix header modify action validation") Cc: stable@dpdk.org Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index c8035b352e..794afcf18c 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -435,7 +435,6 @@ flow_dv_convert_modify_action(struct rte_flow_item *item, /* Fetch variable byte size mask from the array. */ mask = flow_dv_fetch_field((const uint8_t *)item->mask + field->offset, field->size); - MLX5_ASSERT(mask); if (!mask) { ++field; continue;