From: Bruce Richardson Date: Thu, 28 Aug 2014 15:42:34 +0000 (+0100) Subject: ixgbe: keep only non-zero initializer in mbuf definition X-Git-Tag: spdx-start~10440 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=cafa59684660640c8bf847547613a48bc7a9d37c;p=dpdk.git ixgbe: keep only non-zero initializer in mbuf definition Since all unspecified fields in an initializer are assumed to be zero we can simplify the empty mbuf definition in the vector driver to only use the fields that are non-zero, i.e. just nb_segs = 1. This makes things shorter and means that the structure doesn't need as many updates for other fields being renamed or moved. The variable itself is never modified and only used by a single function so it can be made const and local to the using function. Signed-off-by: Bruce Richardson Acked-by: Pablo de Lara Acked-by: Olivier Matz --- diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c index 92e07de134..56dce2339c 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c @@ -44,33 +44,14 @@ #pragma GCC diagnostic ignored "-Wcast-qual" #endif -static struct rte_mbuf mb_def = { - - .ol_flags = 0, - { - .pkt = { - .data_len = 0, - .pkt_len = 0, - - .vlan_macip = { - .data = 0, - }, - .hash = { - .rss = 0, - }, - - .nb_segs = 1, - .in_port = 0, - - .next = NULL, - .data = NULL, - }, - }, -}; - static inline void ixgbe_rxq_rearm(struct igb_rx_queue *rxq) { + static const struct rte_mbuf mb_def = { + .pkt = { + .nb_segs = 1, + }, + }; int i; uint16_t rx_id; volatile union ixgbe_adv_rx_desc *rxdp;