From: Ouyang Changchun Date: Wed, 21 Jan 2015 03:38:43 +0000 (+0800) Subject: ixgbe: remove an useless check in VF RSS X-Git-Tag: spdx-start~9827 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=d0bd0db1ce96e430aab09a31e8f8849dfe59b839;p=dpdk.git ixgbe: remove an useless check in VF RSS To follow up the comments from Pawel Wodkowski, remove this unnecessary check, as check_mq_mode has already check the queue number in device configure stage, if the queue number of vf is not correct, it will return error code and exit, so it doesn't need check again here in device start stage (note: pf_host_configure is called in device start stage). Fixes: 42d2f78abcb77 ("configure VF RSS") Suggested-by: Pawel Wodkowski Signed-off-by: Changchun Ouyang --- diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c b/lib/librte_pmd_ixgbe/ixgbe_pf.c index 93f6e43392..dbda9b5ac7 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c @@ -187,21 +187,6 @@ int ixgbe_pf_host_configure(struct rte_eth_dev *eth_dev) IXGBE_WRITE_REG(hw, IXGBE_MPSAR_LO(hw->mac.num_rar_entries), 0); IXGBE_WRITE_REG(hw, IXGBE_MPSAR_HI(hw->mac.num_rar_entries), 0); - /* - * VF RSS can support at most 4 queues for each VF, even if - * 8 queues are available for each VF, it need refine to 4 - * queues here due to this limitation, otherwise no queue - * will receive any packet even RSS is enabled. - */ - if (eth_dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_VMDQ_RSS) { - if (RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool == 8) { - RTE_ETH_DEV_SRIOV(eth_dev).active = ETH_32_POOLS; - RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool = 4; - RTE_ETH_DEV_SRIOV(eth_dev).def_pool_q_idx = - dev_num_vf(eth_dev) * 4; - } - } - /* set VMDq map to default PF pool */ hw->mac.ops.set_vmdq(hw, 0, RTE_ETH_DEV_SRIOV(eth_dev).def_vmdq_idx);