From: Kevin Traynor Date: Wed, 6 Nov 2019 19:01:59 +0000 (+0000) Subject: net/ipn3ke: remove useless if statement X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=d28ae28eb7cc1f58984a792ff352c1ed888c4523;p=dpdk.git net/ipn3ke: remove useless if statement Coverity complains that this statement is not needed as the goto label is on the next line anyway. Remove the if statement. 653 ret = ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name); CID 337930 (#1 of 1): Identical code for different branches (IDENTICAL_BRANCHES)identical_branches: The same code is executed when the condition ret is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed? 654 if (ret) 655 goto end; implicit_else: The code from the above if-then branch is identical to the code after the if statement. 656end: Coverity issue: 337930 Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") Cc: stable@dpdk.org Signed-off-by: Kevin Traynor Reviewed-by: David Marchand Reviewed-by: Rosen Xu --- diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.c b/drivers/net/ipn3ke/ipn3ke_ethdev.c index 28d8aaf2d6..af87fda6bc 100644 --- a/drivers/net/ipn3ke/ipn3ke_ethdev.c +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c @@ -737,8 +737,7 @@ ipn3ke_cfg_probe(struct rte_vdev_device *dev) } ret = ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name); - if (ret) - goto end; + end: if (kvlist) rte_kvargs_free(kvlist);