From: Stefan Hajnoczi Date: Wed, 31 Jan 2018 17:48:28 +0000 (+0000) Subject: examples/vhost_scsi: drop unimplemented event index feature X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=d56f6320753585af304c296ff01d8401968fd7f4;p=dpdk.git examples/vhost_scsi: drop unimplemented event index feature The vhost_scsi example application negotiates the VIRTIO_RING_F_EVENT_IDX feature bit but does not honor it when accessing vrings. In particular, commit e37ff954405addb8ea422426a2d162d00dcad196 ("vhost: support virtqueue interrupt/notification suppression") broke vring call because vq->last_used_idx is never updated by vhost_scsi. The vq->last_used_idx field is not even available via the librte_vhost public API, so VIRTIO_RING_F_EVENT_IDX is currently only usable by the built-in virtio_net.c driver in librte_vhost. This patch drops VIRTIO_RING_F_EVENT_IDX from vhost_scsi so that vring call works again. Signed-off-by: Stefan Hajnoczi Reviewed-by: Changpeng Liu Acked-by: Yuanhan Liu --- diff --git a/examples/vhost_scsi/vhost_scsi.c b/examples/vhost_scsi/vhost_scsi.c index da01ad378e..3cb4383e9c 100644 --- a/examples/vhost_scsi/vhost_scsi.c +++ b/examples/vhost_scsi/vhost_scsi.c @@ -21,7 +21,6 @@ #include "scsi_spec.h" #define VIRTIO_SCSI_FEATURES ((1 << VIRTIO_F_NOTIFY_ON_EMPTY) |\ - (1 << VIRTIO_RING_F_EVENT_IDX) |\ (1 << VIRTIO_SCSI_F_INOUT) |\ (1 << VIRTIO_SCSI_F_CHANGE))