From: Markos Chandras Date: Thu, 23 Jun 2016 09:25:52 +0000 (+0100) Subject: net/e1000/base: fix build with gcc 6 X-Git-Tag: spdx-start~6354 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=d5e39d1ca460b149fc0cb2e09b044c1e48b434c2;p=dpdk.git net/e1000/base: fix build with gcc 6 Add the missing braces to the 'if' statements to fix the misleading identation. This also fixes the following build errors when building with gcc >= 6: drivers/net/e1000/base/e1000_phy.c:4156:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation] if (locked) drivers/net/e1000/base/e1000_phy.c:4158:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' if (!ready) drivers/net/e1000/base/e1000_phy.c:4221:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation] if (locked) drivers/net/e1000/base/e1000_phy.c:4223:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' if (!ready) Signed-off-by: Markos Chandras --- diff --git a/drivers/net/e1000/base/e1000_phy.c b/drivers/net/e1000/base/e1000_phy.c index d43b7ce06c..33f478b151 100644 --- a/drivers/net/e1000/base/e1000_phy.c +++ b/drivers/net/e1000/base/e1000_phy.c @@ -4153,12 +4153,13 @@ s32 e1000_read_phy_reg_mphy(struct e1000_hw *hw, u32 address, u32 *data) *data = E1000_READ_REG(hw, E1000_MPHY_DATA); /* Disable access to mPHY if it was originally disabled */ - if (locked) + if (locked) { ready = e1000_is_mphy_ready(hw); if (!ready) return -E1000_ERR_PHY; E1000_WRITE_REG(hw, E1000_MPHY_ADDR_CTRL, E1000_MPHY_DIS_ACCESS); + } return E1000_SUCCESS; } @@ -4218,12 +4219,13 @@ s32 e1000_write_phy_reg_mphy(struct e1000_hw *hw, u32 address, u32 data, E1000_WRITE_REG(hw, E1000_MPHY_DATA, data); /* Disable access to mPHY if it was originally disabled */ - if (locked) + if (locked) { ready = e1000_is_mphy_ready(hw); if (!ready) return -E1000_ERR_PHY; E1000_WRITE_REG(hw, E1000_MPHY_ADDR_CTRL, E1000_MPHY_DIS_ACCESS); + } return E1000_SUCCESS; }