From: Yuanhan Liu Date: Wed, 9 Sep 2015 05:34:35 +0000 (+0800) Subject: vhost: get rid of duplicate code X-Git-Tag: spdx-start~8472 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=dbd897d0a165a4a60879d21720fb6f312f285719;p=dpdk.git vhost: get rid of duplicate code Signed-off-by: Yuanhan Liu Acked-by: Changchun Ouyang Acked-by: Huawei Xie --- diff --git a/lib/librte_vhost/vhost_user/vhost-net-user.c b/lib/librte_vhost/vhost_user/vhost-net-user.c index f406a94cb2..d1f8877d25 100644 --- a/lib/librte_vhost/vhost_user/vhost-net-user.c +++ b/lib/librte_vhost/vhost_user/vhost-net-user.c @@ -329,32 +329,16 @@ vserver_message_handler(int connfd, void *dat, int *remove) ctx.fh = cfd_ctx->fh; ret = read_vhost_message(connfd, &msg); - if (ret < 0) { - RTE_LOG(ERR, VHOST_CONFIG, - "vhost read message failed\n"); - - close(connfd); - *remove = 1; - free(cfd_ctx); - user_destroy_device(ctx); - ops->destroy_device(ctx); - - return; - } else if (ret == 0) { - RTE_LOG(INFO, VHOST_CONFIG, - "vhost peer closed\n"); - - close(connfd); - *remove = 1; - free(cfd_ctx); - user_destroy_device(ctx); - ops->destroy_device(ctx); - - return; - } - if (msg.request > VHOST_USER_MAX) { - RTE_LOG(ERR, VHOST_CONFIG, - "vhost read incorrect message\n"); + if (ret <= 0 || msg.request > VHOST_USER_MAX) { + if (ret < 0) + RTE_LOG(ERR, VHOST_CONFIG, + "vhost read message failed\n"); + else if (ret == 0) + RTE_LOG(INFO, VHOST_CONFIG, + "vhost peer closed\n"); + else + RTE_LOG(ERR, VHOST_CONFIG, + "vhost read incorrect message\n"); close(connfd); *remove = 1;