From: Olivier Matz Date: Mon, 23 Jan 2017 17:11:03 +0000 (+0100) Subject: mempool: fix stack handler dequeue X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=e09ff22d538e13ead91a5caa2d136e8e065e5ed1;p=dpdk.git mempool: fix stack handler dequeue The return value of the stack handler is wrong: it should be 0 on success, not the number of objects dequeued. This could lead to memory leaks depending on how the caller checks the return value (ret < 0 or ret != 0). This was also breaking autotests with debug enabled, because the debug cookies are only updated when the function returns 0, so the cookies were not updated, leading to an abort(). Fixes: 295a530b0844 ("mempool: add stack mempool handler") Cc: stable@dpdk.org Signed-off-by: Olivier Matz --- diff --git a/lib/librte_mempool/rte_mempool_stack.c b/lib/librte_mempool/rte_mempool_stack.c index 5fd8af24e0..817f77e665 100644 --- a/lib/librte_mempool/rte_mempool_stack.c +++ b/lib/librte_mempool/rte_mempool_stack.c @@ -118,7 +118,7 @@ stack_dequeue(struct rte_mempool *mp, void **obj_table, s->len -= n; rte_spinlock_unlock(&s->sl); - return n; + return 0; } static unsigned