From: Jingjing Wu Date: Tue, 15 Dec 2015 16:23:07 +0000 (+0800) Subject: i40e: fix flow director index sign X-Git-Tag: spdx-start~7707 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=e34189abaff977cb20ca317ac179ab7ad49c380d;p=dpdk.git i40e: fix flow director index sign Coverity issue reported like CID 119268 (#1 of 1): Unintended sign extension (SIGN_EXTENSION)sign_extension: Suspicious implicit sign extension: vsi_id with type unsigned short (16 bits, unsigned) is promoted in vsi_id << 23 to type int (32 bits, signed), then sign-extended to type unsigned long (64 bits, unsigned). If vsi_id << 23 is greater than 0x7FFFFFFF, the upper bits of the result will all be 1. Fixes: 88ebc2b7f976 ("i40e: extend flow director to support VF") Signed-off-by: Jingjing Wu Acked-by: John McNamara --- diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index 43a39ecfa6..9ad6981c49 100644 --- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c @@ -1091,7 +1091,7 @@ i40e_fdir_filter_programming(struct i40e_pf *pf, /* Use LAN VSI Id by default */ vsi_id = pf->main_vsi->vsi_id; fdirdp->qindex_flex_ptype_vsi |= - rte_cpu_to_le_32((vsi_id << + rte_cpu_to_le_32(((uint32_t)vsi_id << I40E_TXD_FLTR_QW0_DEST_VSI_SHIFT) & I40E_TXD_FLTR_QW0_DEST_VSI_MASK);