From: Didier Pallard Date: Tue, 11 Dec 2018 17:25:01 +0000 (+0100) Subject: net/i40e: revert fix offload not supported mask X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=e51da4bbaf3584e16cbd0ea0b1b85343b777134f;p=dpdk.git net/i40e: revert fix offload not supported mask This reverts commit 09a62d75691f ("net/i40e: fix offload not supported mask") Contrary to what is said in above patch commit log, I40E_TX_OFFLOAD_NOTSUP_MASK is the mask of Tx offload bits that are part of PKT_TX_OFFLOAD_MASK but not included in I40E_TX_OFFLOAD_MASK. Above patch erroneously includes all PKT_RX_OFFLOAD_ bits in the I40E_TX_OFFLOAD_NOTSUP_MASK, this is not what is expected. Restore the initial xor that gives the expected result. Fixes: 09a62d75691f ("net/i40e: fix offload not supported mask") Cc: stable@dpdk.org Signed-off-by: Didier Pallard Acked-by: Qi Zhang --- diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index e1152ff0ea..ab74a488f8 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -69,7 +69,7 @@ I40E_TX_IEEE1588_TMST) #define I40E_TX_OFFLOAD_NOTSUP_MASK \ - ~(PKT_TX_OFFLOAD_MASK & I40E_TX_OFFLOAD_MASK) + (PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK) static inline void i40e_rxd_to_vlan_tci(struct rte_mbuf *mb, volatile union i40e_rx_desc *rxdp)