From: Gowrishankar Muthukrishnan Date: Tue, 6 Mar 2018 09:37:04 +0000 (+0530) Subject: net/bonding: fix primary slave port id storage type X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=e54b560d2892e540567476e2588be42dbd15d957;p=dpdk.git net/bonding: fix primary slave port id storage type primary_slave_port_id is uint16_t which needs to be correctly stored with the same data type of input parameter in bond_ethdev_configure. In powerpc, creating bond pmd results in below error due to wrong cast on input param. This is reproducible, only when using shared libraries. sudo -E LD_LIBRARY_PATH=$PWD/$RTE_TARGET/lib $RTE_TARGET/app/testpmd \ -l 0,8 --socket-mem=1024,1024 \ --vdev 'net_tap0,iface=dpdktap0' --vdev 'net_tap1,iface=dpdktap1' \ --vdev 'net_bonding0,mode=1,slave=0,slave=1,primary=0,socket_id=1' \ -d $RTE_TARGET/lib/librte_pmd_tap.so \ -d $RTE_TARGET/lib/librte_mempool_ring.so -- --forward-mode=rxonly Configuring Port 0 (socket 0) PMD: net_tap0: 0x70a854070280: TX configured queues number: 1 PMD: net_tap0: 0x70a854070280: RX configured queues number: 1 Port 0: 86:EA:6D:52:3E:DB Configuring Port 1 (socket 0) PMD: net_tap1: 0x70a854074300: TX configured queues number: 1 PMD: net_tap1: 0x70a854074300: RX configured queues number: 1 Port 1: 42:9A:B8:49:B6:00 Configuring Port 2 (socket 1) EAL: Failed to set primary slave port 7424 on bonded device net_bonding0 Fail to configure port 2 EAL: Error - exiting with code: 1 Cause: Start ports failed Fixes: f8244c6399 ("ethdev: increase port id range") Cc: stable@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Ferruh Yigit --- diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c index 27d3101b90..e99681e2d4 100644 --- a/drivers/net/bonding/rte_eth_bond_args.c +++ b/drivers/net/bonding/rte_eth_bond_args.c @@ -244,7 +244,7 @@ bond_ethdev_parse_primary_slave_port_id_kvarg(const char *key __rte_unused, if (primary_slave_port_id < 0) return -1; - *(uint8_t *)extra_args = (uint8_t)primary_slave_port_id; + *(uint16_t *)extra_args = (uint16_t)primary_slave_port_id; return 0; }