From: Andy Green Date: Mon, 14 May 2018 05:01:07 +0000 (+0800) Subject: app/bbdev: use strcpy for allocated string X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=f2790f9cf8486b01576c6ddfd60d2ce434a2b3e4;p=dpdk.git app/bbdev: use strcpy for allocated string app/test-bbdev/test_bbdev_vector.c:895:3: error: ‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation] strncpy(entry, line, strlen(line)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ app/test-bbdev/test_bbdev_vector.c:917:5: error: ‘strncat’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation] strncat(entry, line, strlen(line)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: stable@dpdk.org Signed-off-by: Andy Green Reviewed-by: Ferruh Yigit --- diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c index a37e35f4d4..81b8ee78f6 100644 --- a/app/test-bbdev/test_bbdev_vector.c +++ b/app/test-bbdev/test_bbdev_vector.c @@ -891,8 +891,7 @@ test_bbdev_vector_read(const char *filename, goto exit; } - memset(entry, 0, strlen(line) + 1); - strncpy(entry, line, strlen(line)); + strcpy(entry, line); /* check if entry ends with , or = */ if (entry[strlen(entry) - 1] == ',' @@ -914,7 +913,8 @@ test_bbdev_vector_read(const char *filename, } entry = entry_extended; - strncat(entry, line, strlen(line)); + /* entry has been allocated accordingly */ + strcpy(&entry[strlen(entry)], line); if (entry[strlen(entry) - 1] != ',') break;