From: Weiguo Li Date: Tue, 1 Mar 2022 06:08:30 +0000 (+0800) Subject: net/txgbe: fix queue statistics mapping X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=f69467177fa34afaeeeae81ad83142121ee1bc98;p=dpdk.git net/txgbe: fix queue statistics mapping Since boolean value is in 0 and 1, it's strange to combines a boolean value with a bit operator. Thus it's highly possible a typo error with "if (A & !B)", and more probably to use "if (A & ~B)" instead. Fixes: c1d4e9d37abd ("net/txgbe: add queue stats mapping") Cc: stable@dpdk.org Signed-off-by: Weiguo Li Acked-by: Jiawen Wu --- diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 19d4444748..f0994f028d 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -376,7 +376,7 @@ txgbe_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev, if (hw->mac.type != txgbe_mac_raptor) return -ENOSYS; - if (stat_idx & !QMAP_FIELD_RESERVED_BITS_MASK) + if (stat_idx & ~QMAP_FIELD_RESERVED_BITS_MASK) return -EIO; PMD_INIT_LOG(DEBUG, "Setting port %d, %s queue_id %d to stat index %d",