From: Joyce Kong Date: Mon, 21 Dec 2020 14:23:18 +0000 (+0800) Subject: net/virtio: remove unnecessary read memory barrier X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=f875cbfd47ce9181ac421d8b57703df1c0d5f49f;p=dpdk.git net/virtio: remove unnecessary read memory barrier As desc_is_used has a load-acquire or rte_io_rmb inside and wait for used desc in virtqueue, it is ok to remove virtio_rmb behind it. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Maxime Coquelin --- diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 54a6d6ca95..9600624d08 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -209,12 +209,12 @@ virtio_send_command_packed(struct virtnet_ctl *cvq, virtio_wmb(vq->hw->weak_barriers); virtqueue_notify(vq); - /* wait for used descriptors in virtqueue */ + /* wait for used desc in virtqueue + * desc_is_used has a load-acquire or rte_io_rmb inside + */ while (!desc_is_used(&desc[head], vq)) usleep(100); - virtio_rmb(vq->hw->weak_barriers); - /* now get used descriptors */ vq->vq_free_cnt += nb_descs; vq->vq_used_cons_idx += nb_descs;