From: Cheng Jiang Date: Wed, 3 Feb 2021 14:29:04 +0000 (+0000) Subject: examples/vhost: add error propagation in ioat ops X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=fa545ed3da44ae1ef083a7eb9be2d1c2f6ddc7eb;p=dpdk.git examples/vhost: add error propagation in ioat ops This patch adds add error propagation for rte_ioat_completed_ops call, and also changes dev_id type from int to uint16_t. Signed-off-by: Cheng Jiang Reviewed-by: Maxime Coquelin --- diff --git a/examples/vhost/ioat.c b/examples/vhost/ioat.c index dbad28d43e..60b73be936 100644 --- a/examples/vhost/ioat.c +++ b/examples/vhost/ioat.c @@ -22,7 +22,6 @@ struct packet_tracker { struct packet_tracker cb_tracker[MAX_VHOST_DEVICE]; - int open_ioat(const char *value) { @@ -129,7 +128,7 @@ ioat_transfer_data_cb(int vid, uint16_t queue_id, struct rte_vhost_async_status *opaque_data, uint16_t count) { uint32_t i_desc; - int dev_id = dma_bind[vid].dmas[queue_id * 2 + VIRTIO_RXQ].dev_id; + uint16_t dev_id = dma_bind[vid].dmas[queue_id * 2 + VIRTIO_RXQ].dev_id; struct rte_vhost_iov_iter *src = NULL; struct rte_vhost_iov_iter *dst = NULL; unsigned long i_seg; @@ -182,10 +181,17 @@ ioat_check_completed_copies_cb(int vid, uint16_t queue_id, unsigned short mask = MAX_ENQUEUED_SIZE - 1; unsigned short i; - int dev_id = dma_bind[vid].dmas[queue_id * 2 + uint16_t dev_id = dma_bind[vid].dmas[queue_id * 2 + VIRTIO_RXQ].dev_id; n_seg = rte_ioat_completed_ops(dev_id, 255, dump, dump); - if (n_seg <= 0) + if (n_seg < 0) { + RTE_LOG(ERR, + VHOST_DATA, + "fail to poll completed buf on IOAT device %u", + dev_id); + return 0; + } + if (n_seg == 0) return 0; cb_tracker[dev_id].ioat_space += n_seg;