From: Sunil Pai G Date: Wed, 12 Feb 2020 05:37:10 +0000 (+0000) Subject: net/ice: fix unchecked Tx cleanup error X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=fe38133c42d846613a41beff49ab0e1b9a3e0e61;p=dpdk.git net/ice: fix unchecked Tx cleanup error Coverity complains of unchecked return value warning of ice_xmit_cleanup, while this cleanup is opportunistic and will not cause problems if it fails. So instead of checking the return value of ice_xmit_cleanup and return in case of cleanup failure, we directly cast it to void function to make the Coverity happy. Coverity issue: 353623 Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") Cc: stable@dpdk.org Signed-off-by: Sunil Pai G Acked-by: Xiaolong Ye --- diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index ce5b8e6ca3..60c411bfad 100644 --- a/drivers/net/ice/ice_rxtx.c +++ b/drivers/net/ice/ice_rxtx.c @@ -2471,7 +2471,7 @@ ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) /* Check if the descriptor ring needs to be cleaned. */ if (txq->nb_tx_free < txq->tx_free_thresh) - ice_xmit_cleanup(txq); + (void)ice_xmit_cleanup(txq); for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) { tx_pkt = *tx_pkts++;