From 7dee8c79483e370a346d68060b0b890b273e9a46 Mon Sep 17 00:00:00 2001 From: Aaron Conole Date: Mon, 15 Apr 2019 10:48:18 -0400 Subject: [PATCH] net/virtio: fix dangling pointer on failure When eth_virtio_dev_init() is cleaning up, it does not correctly set the mac_addrs variable to NULL, which will lead to a double free. Found during unit-test fixes. Fixes: 43d18765c027 ("net/virtio: fix memory leak on failure") Cc: stable@dpdk.org Reported-by: Michael Santana Signed-off-by: Aaron Conole Reviewed-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 2272bb2e56..d25c08f0a2 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1862,6 +1862,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev) out: rte_free(eth_dev->data->mac_addrs); + eth_dev->data->mac_addrs = NULL; return ret; } -- 2.20.1