From b5743da31eba03cdc7abae3295f8ba852919c4a3 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Mon, 14 Aug 2017 14:32:24 +0300 Subject: [PATCH] net/mlx5: fix locking in xstats functions The corrupted code didn't unlock the spinlock in xstats get and reset functions error flow. Hence, if these errors happened, the device spinlock was left locked and many mlx5 device functionalities were blocked. The fix unlocks the spinlock in the missed places. Fixes: e62bc9e70608 ("net/mlx5: fix extended statistics") Cc: stable@dpdk.org Signed-off-by: Matan Azrad Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_stats.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c index 7b45c8c7da..d443e13366 100644 --- a/drivers/net/mlx5/mlx5_stats.c +++ b/drivers/net/mlx5/mlx5_stats.c @@ -435,8 +435,10 @@ mlx5_xstats_get(struct rte_eth_dev *dev, priv_lock(priv); stats_n = priv_ethtool_get_stats_n(priv); - if (stats_n < 0) + if (stats_n < 0) { + priv_unlock(priv); return -1; + } if (xstats_ctrl->stats_n != stats_n) priv_xstats_init(priv); ret = priv_xstats_get(priv, stats); @@ -461,10 +463,11 @@ mlx5_xstats_reset(struct rte_eth_dev *dev) priv_lock(priv); stats_n = priv_ethtool_get_stats_n(priv); if (stats_n < 0) - return; + goto unlock; if (xstats_ctrl->stats_n != stats_n) priv_xstats_init(priv); priv_xstats_reset(priv); +unlock: priv_unlock(priv); } -- 2.20.1