From e5e193acf09c9d4b08e8ed7f2bf9a61b5c204fff Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Sat, 3 Nov 2018 14:58:53 +0000 Subject: [PATCH] crypto/scheduler: fix build with gcc 8.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit build_error: drivers/crypto/scheduler/scheduler_pmd.c: In function ‘parse_name_arg’: drivers/crypto/scheduler/scheduler_pmd.c:372:2: error: ‘strncpy’ specified bound 64 equals destination size [-Werror=stringop-truncation] strncpy(params->name, value, RTE_CRYPTODEV_NAME_MAX_LEN); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ strncpy may result a not null-terminated string, replaced it with strlcpy Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver") Cc: stable@dpdk.org Signed-off-by: Jerin Jacob --- drivers/crypto/scheduler/scheduler_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c index 20198ccb02..a1632a2b91 100644 --- a/drivers/crypto/scheduler/scheduler_pmd.c +++ b/drivers/crypto/scheduler/scheduler_pmd.c @@ -369,7 +369,7 @@ parse_name_arg(const char *key __rte_unused, return -EINVAL; } - strncpy(params->name, value, RTE_CRYPTODEV_NAME_MAX_LEN); + strlcpy(params->name, value, RTE_CRYPTODEV_NAME_MAX_LEN); return 0; } -- 2.20.1