From 4b1b380213f3fc7029e8b9d936fc0a5d25009422 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Tue, 3 Mar 2015 15:48:28 +0100 Subject: [PATCH] bond: remove debug function to fix link with shared lib The function print_client_stats was used in the example without being clearly exported in the map file. So it breaks linking with shared library when debug is enabled. It's better to remove this function as it probably could be implemented with statistics API. Fixes: cc7e8ae84faa ("add example application for link bonding mode 6") Signed-off-by: Thomas Monjalon Acked-by: Declan Doherty --- examples/bond/main.c | 5 ----- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 13 ------------- 2 files changed, 18 deletions(-) diff --git a/examples/bond/main.c b/examples/bond/main.c index e4457f2e84..7da6bfcd1a 100644 --- a/examples/bond/main.c +++ b/examples/bond/main.c @@ -650,7 +650,6 @@ cmdline_parse_inst_t cmd_quit = { }, }; -extern void print_client_stats(void); struct cmd_show_result { cmdline_fixed_string_t show; }; @@ -680,10 +679,6 @@ static void cmd_show_parsed(__attribute__((unused)) void *parsed_result, global_flag_stru_p->port_packets[1], global_flag_stru_p->port_packets[2]); rte_spinlock_unlock(&global_flag_stru_p->lock); - -#if defined(RTE_LIBRTE_BOND_DEBUG_ALB_L1) || defined(RTE_LIBRTE_BOND_DEBUG_ALB) - print_client_stats(); -#endif } cmdline_parse_token_string_t cmd_show_show = diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c index 7dee5f24e1..af8113e99c 100644 --- a/lib/librte_pmd_bond/rte_eth_bond_pmd.c +++ b/lib/librte_pmd_bond/rte_eth_bond_pmd.c @@ -279,19 +279,6 @@ update_client_stats(uint32_t addr, uint8_t port, uint32_t *TXorRXindicator) } -void print_client_stats(void); -void print_client_stats(void) -{ - int i = 0; - char buf[MaxIPv4String]; - - for (; i < active_clients; i++) { - ipv4_addr_to_dot(client_stats[i].ipv4_addr, buf, MaxIPv4String); - printf("port:%d client:%s RX:%d TX:%d\n", client_stats[i].port, buf, - client_stats[i].ipv4_rx_packets, - client_stats[i].ipv4_tx_packets); - } -} #ifdef RTE_LIBRTE_BOND_DEBUG_ALB #define MODE6_DEBUG(info, src_ip, dst_ip, eth_h, arp_op, port, burstnumber) \ RTE_LOG(DEBUG, PMD, \ -- 2.20.1