From 00cc9701e4d3390f80d5f7e8109587fe342718a9 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 2 Apr 2019 18:09:46 +0100 Subject: [PATCH] mbuf: update Tx VLAN and QinQ flags documentation Currently PKT_TX_VLAN and PKT_TX_QINQ mbuf flags are documented as they are to say packet contains VLAN or QINQ information. Updating the definition as they are requests from application to driver to insert VLAN or double VLAN tags into packet. Fixes: dc6c911c9993 ("mbuf: use reserved space for double vlan") Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.h | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index f7886dcb30..a6c4a5e183 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -280,9 +280,11 @@ extern "C" { #define PKT_TX_TUNNEL_MASK (0xFULL << 45) /** - * Second VLAN insertion (QinQ) flag. + * Double VLAN insertion (QinQ) request to driver, driver may offload the + * insertion based on device capability. + * mbuf 'vlan_tci' & 'vlan_tci_outer' must be valid when this flag is set. */ -#define PKT_TX_QINQ (1ULL << 49) /**< TX packet with double VLAN inserted. */ +#define PKT_TX_QINQ (1ULL << 49) /* this old name is deprecated */ #define PKT_TX_QINQ_PKT PKT_TX_QINQ @@ -338,7 +340,9 @@ extern "C" { #define PKT_TX_IPV6 (1ULL << 56) /** - * TX packet is a 802.1q VLAN packet. + * VLAN tag insertion request to driver, driver may offload the insertion + * based on the device capability. + * mbuf 'vlan_tci' field must be valid when this flag is set. */ #define PKT_TX_VLAN (1ULL << 57) /* this old name is deprecated */ -- 2.20.1