From 05271b99a93ae306fe4abe09fa561f0220469724 Mon Sep 17 00:00:00 2001 From: Stephen Douthit Date: Mon, 28 Feb 2022 10:29:35 -0500 Subject: [PATCH] net/ixgbe: fix FSP check for X550EM devices Currently all X500EM* MAC types fall through to the default case and get reported as non-SFP regardless of media type, which isn't correct. Fixes: 0790adeb5675 ("ixgbe/base: support X550em_a device") Cc: stable@dpdk.org Signed-off-by: Stephen Douthit Signed-off-by: Jeff Daly Acked-by: Haiyue Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 7643842560..2da3f67bbc 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -781,6 +781,20 @@ ixgbe_is_sfp(struct ixgbe_hw *hw) case ixgbe_phy_sfp_passive_unknown: return 1; default: + /* x550em devices may be SFP, check media type */ + switch (hw->mac.type) { + case ixgbe_mac_X550EM_x: + case ixgbe_mac_X550EM_a: + switch (ixgbe_get_media_type(hw)) { + case ixgbe_media_type_fiber: + case ixgbe_media_type_fiber_qsfp: + return 1; + default: + break; + } + default: + break; + } return 0; } } -- 2.39.5