From 07580a734b99df9984da47a5ea844ba65d69f929 Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Tue, 12 May 2020 16:29:01 +0100 Subject: [PATCH] telemetry: check socket creation failure The return value from the socket function is now checked, as it can return a negative value on error. Coverity issue: 358443 Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Signed-off-by: Ciara Power Acked-by: Kevin Laatz --- lib/librte_telemetry/telemetry_legacy.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/librte_telemetry/telemetry_legacy.c b/lib/librte_telemetry/telemetry_legacy.c index 72471cbfbe..2de9021349 100644 --- a/lib/librte_telemetry/telemetry_legacy.c +++ b/lib/librte_telemetry/telemetry_legacy.c @@ -95,6 +95,10 @@ register_client(const char *cmd __rte_unused, const char *params, *strchr(data, '\"') = 0; fd = socket(AF_UNIX, SOCK_SEQPACKET, 0); + if (fd < 0) { + perror("Failed to open socket"); + return -1; + } addrs.sun_family = AF_UNIX; strlcpy(addrs.sun_path, data, sizeof(addrs.sun_path)); -- 2.20.1