From 0934b7f12aabc960b6a1ad5c6f4d5f591e8c787c Mon Sep 17 00:00:00 2001 From: Allain Legacy Date: Fri, 10 Mar 2017 09:38:21 -0500 Subject: [PATCH] net/e1000: advertise offload capabilities for the EM PMD The hardware offload capabilities are not being advertised for the EM PMD. Because of this, applications that only enable these features if the device advertises them will never do so. Normally this is not an issue since normal packet processing should work even if hardware offload is not available. But, in older versions of Virtual Box the e1000 device emulation (Intel PRO/1000 MT Desktop 82540EM) assumes that it should enable VLAN stripping even if the driver does not request it. This means that any ingress packets that have a VLAN tag will be stripped. Since the application did not request to enable VLAN stripping it is not expecting these packets so they are not processed as VLAN packets. Regardless of the Virtual Box issue, the driver should be advertising supported capabilities as is done in other drivers. Signed-off-by: Allain Legacy Acked-by: Wenzhuo Lu --- drivers/net/e1000/em_ethdev.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 4f34c14cdd..7110af344a 100644 --- a/drivers/net/e1000/em_ethdev.c +++ b/drivers/net/e1000/em_ethdev.c @@ -1088,6 +1088,16 @@ eth_em_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->min_rx_bufsize = 256; /* See BSIZE field of RCTL register. */ dev_info->max_rx_pktlen = em_get_max_pktlen(hw); dev_info->max_mac_addrs = hw->mac.rar_entry_count; + dev_info->rx_offload_capa = + DEV_RX_OFFLOAD_VLAN_STRIP | + DEV_RX_OFFLOAD_IPV4_CKSUM | + DEV_RX_OFFLOAD_UDP_CKSUM | + DEV_RX_OFFLOAD_TCP_CKSUM; + dev_info->tx_offload_capa = + DEV_TX_OFFLOAD_VLAN_INSERT | + DEV_TX_OFFLOAD_IPV4_CKSUM | + DEV_TX_OFFLOAD_UDP_CKSUM | + DEV_TX_OFFLOAD_TCP_CKSUM; /* * Starting with 631xESB hw supports 2 TX/RX queues per port. -- 2.20.1