From 0b39cc820ae57319d9d9a3609843c94d0b9a4bbb Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Tue, 10 Apr 2018 13:32:06 +0000 Subject: [PATCH] net/vdev_netvsc: remove specified devices IP check If the netvsc driver starts in blacklist mode, it does not automatically probe IP associated netvsc devices. Therefore, the only way to probe them is to specify them by the EAL command line, using the "force" parameter to skip the IP check in the driver. >From now on, the user does not need to add the "force" parameter if he specifies an IP associated netvsc device by the EAL command line, and the responsibility of the IP check is now in the user's hands. However, in the absence of any specification, the driver still skips IP associated netvsc devices. Cc: stable@dpdk.org Signed-off-by: Matan Azrad --- doc/guides/nics/vdev_netvsc.rst | 10 +++++++--- drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/vdev_netvsc.rst b/doc/guides/nics/vdev_netvsc.rst index 1c3084dda2..e02ae9acba 100644 --- a/doc/guides/nics/vdev_netvsc.rst +++ b/doc/guides/nics/vdev_netvsc.rst @@ -89,12 +89,16 @@ The following device parameters are supported: - ``force`` [int] If nonzero, forces the use of specified interfaces even if not detected as - NetVSC or detected as routed NETVSC. + NetVSC. - ``ignore`` [int] If nonzero, ignores the driver runnig (actually used to disable the auto-detection in Hyper-V VM). -Not specifying either ``iface`` or ``mac`` makes this driver attach itself to -all unrouted NetVSC interfaces found on the system. +.. note:: + + Not specifying either ``iface`` or ``mac`` makes this driver attach itself to + all unrouted NetVSC interfaces found on the system. + Specifying the device makes this driver attach itself to the device + regardless the device routes. diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index f83aab4feb..ed040be18f 100644 --- a/drivers/net/vdev_netvsc/vdev_netvsc.c +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c @@ -569,7 +569,7 @@ vdev_netvsc_netvsc_probe(const struct if_nameindex *iface, /* Routed NetVSC should not be probed. */ if (vdev_netvsc_has_route(iface, AF_INET) || vdev_netvsc_has_route(iface, AF_INET6)) { - if (!specified || !force) + if (!specified) return 0; DRV_LOG(WARNING, "probably using routed NetVSC interface \"%s\"" " (index %u)", iface->if_name, iface->if_index); -- 2.20.1