From 0d8063fef63816c8ab5033aae7bfbfee4804a5b0 Mon Sep 17 00:00:00 2001 From: Lavanya Govindarajan Date: Mon, 10 Jun 2019 14:07:38 +0100 Subject: [PATCH] net/iavf: move compile time define to configuration DEBUG_DUMP_DESC flag is commented out in IAVF Makefile and to enable it user needs to edit the Makefile. It is felt that this method is not good. Hence removing this flag from IAVF makefile and adding a flag CONFIG_RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC to config/common_base. Signed-off-by: Lavanya Govindarajan Acked-by: Qi Zhang --- config/common_base | 1 + drivers/net/iavf/Makefile | 3 --- drivers/net/iavf/iavf_rxtx.h | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/config/common_base b/config/common_base index e406e7836a..5cb73a7a82 100644 --- a/config/common_base +++ b/config/common_base @@ -327,6 +327,7 @@ CONFIG_RTE_LIBRTE_IAVF_INC_VECTOR=y CONFIG_RTE_LIBRTE_IAVF_DEBUG_TX=n CONFIG_RTE_LIBRTE_IAVF_DEBUG_TX_FREE=n CONFIG_RTE_LIBRTE_IAVF_DEBUG_RX=n +CONFIG_RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC=n CONFIG_RTE_LIBRTE_IAVF_16BYTE_RX_DESC=n # # Compile burst-oriented IPN3KE PMD driver diff --git a/drivers/net/iavf/Makefile b/drivers/net/iavf/Makefile index 3a0eb79ca4..cd74e14abc 100644 --- a/drivers/net/iavf/Makefile +++ b/drivers/net/iavf/Makefile @@ -13,9 +13,6 @@ LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash LDLIBS += -lrte_bus_pci -# used to dump HW descriptor for debugging -# CFLAGS += -DDEBUG_DUMP_DESC - EXPORT_MAP := rte_pmd_iavf_version.map LIBABIVER := 1 diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index e821dcae62..c86720bda4 100644 --- a/drivers/net/iavf/iavf_rxtx.h +++ b/drivers/net/iavf/iavf_rxtx.h @@ -255,7 +255,7 @@ void iavf_dump_tx_descriptor(const struct iavf_tx_queue *txq, tx_desc->cmd_type_offset_bsz); } -#ifdef DEBUG_DUMP_DESC +#ifdef RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC #define IAVF_DUMP_RX_DESC(rxq, desc, rx_id) \ iavf_dump_rx_descriptor(rxq, desc, rx_id) #define IAVF_DUMP_TX_DESC(txq, desc, tx_id) \ -- 2.20.1