From 0f7438e6d4009a52482d6a662f440ab067e63c60 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Sat, 8 Jan 2022 16:14:21 +0800 Subject: [PATCH] net/virtio: fix uninitialized RSS key This patch fixes an issue that uninitialized old_rss_key is used for restoring the rss_key. Coverity issue: 373866 Fixes: 0c9d66207054 ("net/virtio: support RSS") Cc: stable@dpdk.org Signed-off-by: Yunjian Wang Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index b317649d7e..d180162abd 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -2028,7 +2028,8 @@ virtio_dev_rss_hash_update(struct rte_eth_dev *dev, return 0; restore_key: - memcpy(hw->rss_key, old_rss_key, VIRTIO_NET_RSS_KEY_SIZE); + if (rss_conf->rss_key && rss_conf->rss_key_len) + memcpy(hw->rss_key, old_rss_key, VIRTIO_NET_RSS_KEY_SIZE); restore_types: hw->rss_hash_types = old_hash_types; -- 2.39.5