From 1123f16eb37b19dcabe2b2313f99911c59df91f3 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Mon, 11 Sep 2017 17:13:29 +0200 Subject: [PATCH] cmdline: fix compilation with -Og MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC cmdline_parse.o cmdline_parse.c: In function ‘match_inst’: cmdline_parse.c:227:5: error: ‘token_p’ may be used uninitialized in this function [-Werror=maybe-uninitialized] if (token_p) { ^ This is a false positive, gcc is not able to see that we always go in the loop at least once, initializing token_p. Fix the warning by initializing token_p to NULL. Signed-off-by: Olivier Matz --- lib/librte_cmdline/cmdline_parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_cmdline/cmdline_parse.c b/lib/librte_cmdline/cmdline_parse.c index 56491eacd4..3e12ee54fd 100644 --- a/lib/librte_cmdline/cmdline_parse.c +++ b/lib/librte_cmdline/cmdline_parse.c @@ -163,7 +163,7 @@ static int match_inst(cmdline_parse_inst_t *inst, const char *buf, unsigned int nb_match_token, void *resbuf, unsigned resbuf_size) { - cmdline_parse_token_hdr_t * token_p; + cmdline_parse_token_hdr_t *token_p = NULL; unsigned int i=0; int n = 0; struct cmdline_token_hdr token_hdr; -- 2.20.1