From 138ae2481e437d7d1549cc59e5ad7129cd87a6a2 Mon Sep 17 00:00:00 2001 From: Adrien Mazarguil Date: Thu, 4 May 2017 19:08:22 +0200 Subject: [PATCH] app/testpmd: fix stack overwriting by flow command The parameter type parser function stores a stack-local address in the global parser context when parsing a "prefix" keyword. This usually translates to "Bad arguments" errors even for correct flow rules as stack gets overwritten by subsequent function calls. Fixes: d3f61b7bad20 ("app/testpmd: add flow item spec prefix length") Cc: stable@dpdk.org Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 0a40005cc7..e952c91a3c 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -1808,6 +1808,8 @@ parse_vc_spec(struct context *ctx, const struct token *token, return -1; /* Parse parameter types. */ switch (ctx->curr) { + static const enum index prefix[] = NEXT_ENTRY(PREFIX); + case ITEM_PARAM_IS: index = 0; objmask = 1; @@ -1822,7 +1824,7 @@ parse_vc_spec(struct context *ctx, const struct token *token, /* Modify next token to expect a prefix. */ if (ctx->next_num < 2) return -1; - ctx->next[ctx->next_num - 2] = NEXT_ENTRY(PREFIX); + ctx->next[ctx->next_num - 2] = prefix; /* Fall through. */ case ITEM_PARAM_MASK: index = 2; -- 2.20.1