From 174572477028b7f04700389e38f87d2ba01a0adc Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 23 May 2014 15:39:24 +0100 Subject: [PATCH] mk: fix linking drivers in static apps The variable CONFIG_RTE_BUILD_SHARED_LIB was in rte.app.mk as "RTE_BUILD_SHARED_LIB", which meant that none of the example apps linked in the PMDs and just didn't work with any eth ports in any static builds. This bug has been introduced in commit 3660cdf990: pcap: convert to use of PMD_REGISTER_DRIVER and fix linking Link for l2fwd before patch: "... -Wl,--whole-archive -Wl,-lrte_kni -Wl,-lrte_timer -Wl,-lrte_hash -Wl,-lrte_lpm -Wl,-lrte_power -Wl,-lrte_meter -Wl,-lrte_sched -Wl,-lm -Wl,-lrt -Wl,--start-group -Wl,-lrte_kvargs -Wl,-lrte_mbuf -Wl,-lethdev -Wl,-lrte_malloc -Wl,-lrte_mempool -Wl,-lrte_ring -Wl,-lrte_eal -Wl,-lrte_cmdline -Wl,-lrt -Wl,-lm -Wl,-ldl -Wl,--end-group -Wl,--no-whole-archive" Link for l2fwd after patch: "... -Wl,--whole-archive -Wl,-lrte_kni -Wl,-lrte_timer -Wl,-lrte_hash -Wl,-lrte_lpm -Wl,-lrte_power -Wl,-lrte_meter -Wl,-lrte_sched -Wl,-lm -Wl,-lrt -Wl,--start-group -Wl,-lrte_kvargs -Wl,-lrte_mbuf -Wl,-lethdev -Wl,-lrte_malloc -Wl,-lrte_mempool -Wl,-lrte_ring -Wl,-lrte_eal -Wl,-lrte_cmdline -Wl,-lrte_pmd_vmxnet3_uio -Wl,-lrte_pmd_virtio_uio -Wl,-lrte_pmd_ixgbe -Wl,-lrte_pmd_e1000 -Wl,-lrte_pmd_ring -Wl,-lrt -Wl,-lm -Wl,-ldl -Wl,--end-group -Wl,--no-whole-archive" Signed-off-by: Bruce Richardson Acked-by: Thomas Monjalon --- mk/rte.app.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 38c68b87a3..a8365775f1 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -151,7 +151,7 @@ LDLIBS += -lrte_pmd_xenvirt LDLIBS += -lxenstore endif -ifeq ($(RTE_BUILD_SHARED_LIB),n) +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n) ifeq ($(CONFIG_RTE_LIBRTE_VMXNET3_PMD),y) LDLIBS += -lrte_pmd_vmxnet3_uio -- 2.20.1