From 18839177b8af62d2ab912d9b3afa6f0e40f83554 Mon Sep 17 00:00:00 2001 From: Anoob Joseph Date: Sat, 16 May 2020 14:56:53 +0530 Subject: [PATCH] common/octeontx2: fix port ID bound check Fix out of bounds access. Coverity issue: 354230, 354231 Fixes: f44e71637755 ("net/octeontx2: add security session operations") Fixes: 3fe4d07d1678 ("crypto/octeontx2: enable CPT to share QP with ethdev") Cc: stable@dpdk.org Signed-off-by: Anoob Joseph --- drivers/common/octeontx2/otx2_sec_idev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/octeontx2/otx2_sec_idev.c b/drivers/common/octeontx2/otx2_sec_idev.c index 4e65ce2a34..6e9643c383 100644 --- a/drivers/common/octeontx2/otx2_sec_idev.c +++ b/drivers/common/octeontx2/otx2_sec_idev.c @@ -55,7 +55,7 @@ otx2_sec_idev_tx_cpt_qp_add(uint16_t port_id, struct otx2_cpt_qp *qp) struct otx2_sec_idev_cfg *cfg; int i, ret; - if (qp == NULL || port_id > OTX2_MAX_INLINE_PORTS) + if (qp == NULL || port_id >= OTX2_MAX_INLINE_PORTS) return -EINVAL; cfg = &sec_cfg[port_id]; @@ -126,7 +126,7 @@ otx2_sec_idev_tx_cpt_qp_get(uint16_t port_id, struct otx2_cpt_qp **qp) uint16_t index; int i, ret; - if (port_id > OTX2_MAX_INLINE_PORTS || qp == NULL) + if (port_id >= OTX2_MAX_INLINE_PORTS || qp == NULL) return -EINVAL; cfg = &sec_cfg[port_id]; -- 2.20.1