From 19bfa4ddb1a983b6810b7d054a6fbc8360f86d73 Mon Sep 17 00:00:00 2001 From: Panu Matilainen Date: Thu, 15 Oct 2015 14:49:05 +0300 Subject: [PATCH] eal: make the -n argument optional Obtaining the correct value of memory channels, especially from a running system, can be anything from difficult to plain impossible. Since the value is merely an optimization and does not affect functionality otherwise, its pointless to force such a guess on users initially, such things belong to performance tuning phase. Signed-off-by: Panu Matilainen Acked-by: David Marchand --- lib/librte_eal/common/eal_common_options.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 1f459accd3..a4cdbaa788 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -834,12 +834,6 @@ eal_check_common_options(struct internal_config *internal_cfg) RTE_LOG(ERR, EAL, "Invalid process type specified\n"); return -1; } - if (internal_cfg->process_type == RTE_PROC_PRIMARY && - internal_cfg->force_nchannel == 0) { - RTE_LOG(ERR, EAL, "Number of memory channels (-n) not " - "specified\n"); - return -1; - } if (index(internal_cfg->hugefile_prefix, '%') != NULL) { RTE_LOG(ERR, EAL, "Invalid char, '%%', in --"OPT_FILE_PREFIX" " "option\n"); @@ -869,7 +863,7 @@ eal_check_common_options(struct internal_config *internal_cfg) void eal_common_usage(void) { - printf("-c COREMASK|-l CORELIST -n CHANNELS [options]\n\n" + printf("-c COREMASK|-l CORELIST [options]\n\n" "EAL common options:\n" " -c COREMASK Hexadecimal bitmask of cores to run on\n" " -l CORELIST List of cores to run on\n" -- 2.20.1