From 1ae1b8c72d33a1d11ba82178c924ee7df3fd6c9a Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Tue, 30 Jan 2018 14:13:39 +0000 Subject: [PATCH] app/testpmd: fix port validation rte_eth_dev_is_valid_port() API validates each valid port from ethdev point of view and may validate ports which should not be used by the application. Testpmd should use only the ports available through the RTE_ETH_FOREACH_DEV iterator. Replace rte_eth_dev_is_valid_port() usage by RTE_ETH_FOREACH_DEV iterator usage for testpmd ports validation. Fixes: 7d89b2610353 ("app/testpmd: use ethdev iterator to list devices") Cc: stable@dpdk.org Signed-off-by: Matan Azrad --- app/test-pmd/config.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 957b82098c..8c920a2c7d 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -756,11 +756,14 @@ port_offload_cap_display(portid_t port_id) int port_id_is_invalid(portid_t port_id, enum print_warning warning) { + uint16_t pid; + if (port_id == (portid_t)RTE_PORT_ALL) return 0; - if (rte_eth_dev_is_valid_port(port_id)) - return 0; + RTE_ETH_FOREACH_DEV(pid) + if (port_id == pid) + return 0; if (warning == ENABLED_WARN) printf("Invalid port %d\n", port_id); -- 2.20.1