From 1b9e9826ad80e5ae56b484c6f6c4bb2df6e8fa70 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Tue, 9 Mar 2021 10:48:35 +0100 Subject: [PATCH] common/mlx5: remove extra line feed in log messages The macro DRV_LOG already includes a terminating line feed character defined in PMD_DRV_LOG_. The extra line feeds added in some messages are removed. Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common_pci.c | 4 ++-- drivers/common/mlx5/mlx5_devx_cmds.c | 2 +- drivers/compress/mlx5/mlx5_compress.c | 2 +- drivers/net/mlx5/linux/mlx5_os.c | 8 ++++---- drivers/net/mlx5/mlx5_flow.c | 2 +- drivers/net/mlx5/windows/mlx5_os.c | 2 +- drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/common/mlx5/mlx5_common_pci.c b/drivers/common/mlx5/mlx5_common_pci.c index 2b657686d1..a7f541a90c 100644 --- a/drivers/common/mlx5/mlx5_common_pci.c +++ b/drivers/common/mlx5/mlx5_common_pci.c @@ -245,14 +245,14 @@ drivers_probe(struct mlx5_pci_device *dev, struct rte_pci_driver *pci_drv, already_loaded = dev->classes_loaded & driver->driver_class; if (already_loaded && !(driver->pci_driver.drv_flags & RTE_PCI_DRV_PROBE_AGAIN)) { - DRV_LOG(ERR, "Device %s is already probed\n", + DRV_LOG(ERR, "Device %s is already probed", pci_dev->device.name); ret = -EEXIST; goto probe_err; } ret = driver->pci_driver.probe(pci_drv, pci_dev); if (ret < 0) { - DRV_LOG(ERR, "Failed to load driver = %s.\n", + DRV_LOG(ERR, "Failed to load driver %s", driver->pci_driver.driver.name); goto probe_err; } diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index 0060c37fc0..8df14f5b7d 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -275,7 +275,7 @@ mlx5_devx_cmd_mkey_create(void *ctx, mkey->obj = mlx5_glue->devx_obj_create(ctx, in, in_size_dw * 4, out, sizeof(out)); if (!mkey->obj) { - DRV_LOG(ERR, "Can't create %sdirect mkey - error %d\n", + DRV_LOG(ERR, "Can't create %sdirect mkey - error %d", klm_num ? "an in" : "a ", errno); rte_errno = errno; mlx5_free(mkey); diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c index 46255ab5e0..85238accff 100644 --- a/drivers/compress/mlx5/mlx5_compress.c +++ b/drivers/compress/mlx5/mlx5_compress.c @@ -257,7 +257,7 @@ mlx5_compress_qp_setup(struct rte_compressdev *dev, uint16_t qp_id, DRV_LOG(ERR, "Can't change SQ state to ready."); goto err; } - DRV_LOG(INFO, "QP %u: SQN=0x%X CQN=0x%X entries num = %u\n", + DRV_LOG(INFO, "QP %u: SQN=0x%X CQN=0x%X entries num = %u", (uint32_t)qp_id, qp->sq.sq->id, qp->cq.cq->id, qp->entries_n); return 0; err: diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index 92fa178b46..1217b510b6 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -1244,14 +1244,14 @@ err_secondary: if (config->hca_attr.log_max_ft_sampler_num > 0 && config->dv_flow_en) { priv->sampler_en = 1; - DRV_LOG(DEBUG, "The Sampler enabled!\n"); + DRV_LOG(DEBUG, "Sampler enabled!"); } else { priv->sampler_en = 0; if (!config->hca_attr.log_max_ft_sampler_num) - DRV_LOG(WARNING, "No available register for" - " Sampler."); + DRV_LOG(WARNING, + "No available register for sampler."); else - DRV_LOG(DEBUG, "DV flow is not supported!\n"); + DRV_LOG(DEBUG, "DV flow is not supported!"); } #endif } diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index ab5be3dacc..773f3e63f4 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -7924,7 +7924,7 @@ void mlx5_release_tunnel_hub(struct mlx5_dev_ctx_shared *sh, uint16_t port_id) if (!thub) return; if (!LIST_EMPTY(&thub->tunnels)) - DRV_LOG(WARNING, "port %u tunnels present\n", port_id); + DRV_LOG(WARNING, "port %u tunnels present", port_id); mlx5_hlist_destroy(thub->groups); mlx5_free(thub); } diff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c index e37cc65c17..e7db85b757 100644 --- a/drivers/net/mlx5/windows/mlx5_os.c +++ b/drivers/net/mlx5/windows/mlx5_os.c @@ -165,7 +165,7 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv) if (!sh->flow_tbls) err = mlx5_alloc_table_hash_list(priv); else - DRV_LOG(DEBUG, "sh->flow_tbls[%p] already created, reuse\n", + DRV_LOG(DEBUG, "sh->flow_tbls[%p] already created, reuse", (void *)sh->flow_tbls); return err; } diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c index 4c2d886bd7..5755a68ec4 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c @@ -751,7 +751,7 @@ mlx5_vdpa_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, priv->pci_dev = pci_dev; priv->var = mlx5_glue->dv_alloc_var(ctx, 0); if (!priv->var) { - DRV_LOG(ERR, "Failed to allocate VAR %u.\n", errno); + DRV_LOG(ERR, "Failed to allocate VAR %u.", errno); goto error; } priv->vdev = rte_vdpa_register_device(&pci_dev->device, -- 2.20.1