From 1c35f666df0786541cd2c83fbad332c1af2a78e7 Mon Sep 17 00:00:00 2001 From: Gaetan Rivet Date: Wed, 26 Jul 2017 13:52:22 +0200 Subject: [PATCH] dev: fix attach proceeding with vdev on PCI success When rte_eal_hotplug_add() successfully probes a PCI device, the return value is zero. The check afterward only returns on error different from -EINVAL. It should return also on success, as there is no need to attempt probing the device with vdev. Fixes: 0bba9e605048 ("eal: use new hotplug API in attach") Cc: stable@dpdk.org Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c index e10b9fd850..d74f978f3b 100644 --- a/lib/librte_eal/common/eal_common_dev.c +++ b/lib/librte_eal/common/eal_common_dev.c @@ -74,7 +74,7 @@ int rte_eal_dev_attach(const char *name, const char *devargs) } ret = rte_eal_hotplug_add("pci", name, devargs); - if (ret && ret != -EINVAL) + if (ret != -EINVAL) return ret; /* -- 2.20.1