From 1ee492bdc4ffeb392f6e7cc0386793c3e53ebb0f Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Tue, 15 Feb 2022 17:30:29 +0000 Subject: [PATCH] buildtools/chkincs: check missing C++ guards Simply compiling a C header with a C++ compiler is not enough to flag missing 'extern "C"' guards. To catch missing guards, we can just use a simple grep for the 'extern "C"' part, and error out if any files have a miss. Signed-off-by: Bruce Richardson Acked-by: Tyler Retzlaff --- buildtools/chkincs/meson.build | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build index 9bb19c9ba3..378c2f19ef 100644 --- a/buildtools/chkincs/meson.build +++ b/buildtools/chkincs/meson.build @@ -37,6 +37,16 @@ if not add_languages('cpp', required: false) subdir_done() endif +# check for extern C in files, since this is not detected as an error by the compiler +grep = find_program('grep', required: false) +if grep.found() + errlist = run_command([grep, '--files-without-match', '^extern "C"', dpdk_chkinc_headers], + check: false, capture: true).stdout().split() + if errlist != [] + error('Files missing C++ \'extern "C"\' guards:\n- ' + '\n- '.join(errlist)) + endif +endif + gen_cpp_files = generator(gen_c_file_for_header, output: '@BASENAME@.cpp', arguments: ['@INPUT@', '@OUTPUT@']) -- 2.20.1