From 20077edf5f09961c7b4434bdd4d48c4353d65507 Mon Sep 17 00:00:00 2001 From: Wei Huang Date: Wed, 17 Mar 2021 04:21:36 -0400 Subject: [PATCH] raw/ifpga/base: check null pointer In init_sec_mgr(), pointer "hw" may be NULL, so "hw" should be checked before dereferencing. Coverity issue: 367483 Fixes: a05bd1b40bde ("raw/ifpga: add FPGA RSU APIs") Signed-off-by: Wei Huang Acked-by: Tianfei Zhang Acked-by: Rosen Xu --- drivers/raw/ifpga/base/ifpga_sec_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/base/ifpga_sec_mgr.c b/drivers/raw/ifpga/base/ifpga_sec_mgr.c index 4cf1db3049..15fb5b6d4d 100644 --- a/drivers/raw/ifpga/base/ifpga_sec_mgr.c +++ b/drivers/raw/ifpga/base/ifpga_sec_mgr.c @@ -610,7 +610,7 @@ int init_sec_mgr(struct ifpga_fme_hw *fme) smgr->rsu_status = NULL; } - if ((hw->pci_data->device_id == IFPGA_N3000_DID) && + if (hw && (hw->pci_data->device_id == IFPGA_N3000_DID) && (hw->pci_data->vendor_id == IFPGA_N3000_VID)) { smgr->ops = &n3000_sec_ops; smgr->copy_speed = IFPGA_N3000_COPY_SPEED; -- 2.20.1