From 219731302a0aa5b8edb30a6bc1cdea64e7824a98 Mon Sep 17 00:00:00 2001 From: Remy Horton Date: Mon, 2 Jul 2018 14:46:08 +0100 Subject: [PATCH] metrics: disallow null as metric name This patch adds a sanity check so that names passed into rte_metrics_reg_names() and the wrapper rte_metrics_reg_name() cannot be NULL. Fixes: 349950ddb9c5 ("metrics: add information metrics library") Cc: stable@dpdk.org Signed-off-by: Remy Horton Acked-by: Ferruh Yigit --- lib/librte_metrics/rte_metrics.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c index 038f58bf84..99a96b651c 100644 --- a/lib/librte_metrics/rte_metrics.c +++ b/lib/librte_metrics/rte_metrics.c @@ -96,6 +96,9 @@ rte_metrics_reg_names(const char * const *names, uint16_t cnt_names) /* Some sanity checks */ if (cnt_names < 1 || names == NULL) return -EINVAL; + for (idx_name = 0; idx_name < cnt_names; idx_name++) + if (names[idx_name] == NULL) + return -EINVAL; memzone = rte_memzone_lookup(RTE_METRICS_MEMZONE_NAME); if (memzone == NULL) -- 2.20.1