From 21ecd2d7ab59060e3123261d1d62a53182029dd0 Mon Sep 17 00:00:00 2001 From: Wei Zhao Date: Wed, 1 Aug 2018 10:54:50 +0800 Subject: [PATCH] net/i40e: revert fix of flow director check This reverts commit 7546dc4a1331340ecb665af9af0a005bb8b657c8. In i40e FDIR PMD code for checking programming status, when the action of add FDIR filter is ok, i40e NIC will not write back to programming status descriptor, so if PMD code check DD is not done after period of time dealy, it means the add or remove filter action is ok. It only write back descriptor when fail. So, there is no issue for the original code. Fixes: 7546dc4a1331 ("net/i40e: fix check of flow director programming status") Cc: stable@dpdk.org Signed-off-by: Wei Zhao Acked-by: Qi Zhang --- drivers/net/i40e/i40e_fdir.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index 2b299c78d8..d41601a176 100644 --- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c @@ -1360,8 +1360,6 @@ i40e_check_fdir_programming_status(struct i40e_rx_queue *rxq) I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1); else I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->rx_tail - 1); - } else { - ret = -1; } return ret; -- 2.20.1