From 26d734b5d280b96f91f00f5e0c6c7eff99facef2 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 14 Apr 2022 13:27:56 +0200 Subject: [PATCH] devargs: fix leak on hotplug failure Caught by ASan, if a secondary process tried to attach a device with an incorrect driver name, devargs was leaked. Fixes: 64051bb1f144 ("devargs: unify scratch buffer storage") Cc: stable@dpdk.org Signed-off-by: David Marchand --- lib/eal/common/eal_common_dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c index c0ee4e442f..9d913e5478 100644 --- a/lib/eal/common/eal_common_dev.c +++ b/lib/eal/common/eal_common_dev.c @@ -180,8 +180,10 @@ local_dev_probe(const char *devargs, struct rte_device **new_dev) return ret; err_devarg: - if (rte_devargs_remove(da) != 0) + if (rte_devargs_remove(da) != 0) { rte_devargs_reset(da); + free(da); + } return ret; } -- 2.39.5