From 272f94e58b01a904b5d8cf66649512b0d62f1a8c Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Tue, 8 Mar 2022 22:02:48 +0100 Subject: [PATCH] devtools: fix symbols check In some environments, the check of local symbols catch-all was failing. Note: this script is called during the build. The reason is that grep returns an error if nothing is found. The option -e of the shell script makes this error fatal. It is not always fatal because the grep is in a command substitution. Fixes: b403498e1422 ("build: hide local symbols in shared libraries") Reported-by: Usama Arif Signed-off-by: Thomas Monjalon --- devtools/check-symbol-maps.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh index 8266fdf9ea..32e1fa5c8f 100755 --- a/devtools/check-symbol-maps.sh +++ b/devtools/check-symbol-maps.sh @@ -53,7 +53,7 @@ if [ -n "$duplicate_symbols" ] ; then ret=1 fi -local_miss_maps=$(grep -L 'local: \*;' $@) +local_miss_maps=$(grep -L 'local: \*;' $@ || true) if [ -n "$local_miss_maps" ] ; then echo "Found maps without local catch-all:" echo "$local_miss_maps" -- 2.39.5