From 2838aa76ba94e0dd7712e57fe6a32651f5690797 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Thu, 13 May 2021 21:40:20 +0300 Subject: [PATCH] vdpa/mlx5: fix device unplug The vDPA PCI device unplug process should release all the private device resources and also to unregister the device. The device unregistration was missed what remained the device data invalid in the rte_vhost library. Unregister the device in unplug process via the remove operation. Fixes: 95276abaaf0a ("vdpa/mlx5: introduce Mellanox vDPA driver") Cc: stable@dpdk.org Reported-by: Eli Britstein Signed-off-by: Matan Azrad Tested-by: Eli Britstein Acked-by: Xueming Li Reviewed-by: Chenbo Xia --- drivers/vdpa/mlx5/mlx5_vdpa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c index 40db28b6db..e5e03e6582 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c @@ -787,6 +787,8 @@ mlx5_vdpa_pci_remove(struct rte_pci_device *pci_dev) mlx5_glue->dv_free_var(priv->var); priv->var = NULL; } + if (priv->vdev) + rte_vdpa_unregister_device(priv->vdev); mlx5_glue->close_device(priv->ctx); pthread_mutex_destroy(&priv->vq_config_lock); rte_free(priv); -- 2.20.1