From 2a5aa6e7a528b16db7da507c975ce3d169d232d4 Mon Sep 17 00:00:00 2001 From: Amr Mokhtar Date: Wed, 31 Jan 2018 14:30:29 +0000 Subject: [PATCH] examples/bbdev: fix memory leak in stats print xstats and xstats_names buffers were allocated for the purpose of printing eth_xstats, but were not freed before exit. A fix is added to free before exit points. Coverity issue: 257013 Fixes: 1ffee690eaa1 ("examples/bbdev: add sample app") Signed-off-by: Amr Mokhtar --- examples/bbdev_app/main.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index a2835a4d4f..e779db2819 100644 --- a/examples/bbdev_app/main.c +++ b/examples/bbdev_app/main.c @@ -585,21 +585,28 @@ print_stats(struct stats_lcore_params *stats_lcore) "Failed to calloc memory for xstats"); ret = rte_eth_xstats_get(port_id, xstats, len); - if (ret < 0 || ret > len) + if (ret < 0 || ret > len) { + free(xstats); rte_exit(EXIT_FAILURE, "rte_eth_xstats_get(%u) len%i failed: %d", port_id, len, ret); + } xstats_names = calloc(len, sizeof(*xstats_names)); - if (xstats_names == NULL) + if (xstats_names == NULL) { + free(xstats); rte_exit(EXIT_FAILURE, "Failed to calloc memory for xstats_names"); + } ret = rte_eth_xstats_get_names(port_id, xstats_names, len); - if (ret < 0 || ret > len) + if (ret < 0 || ret > len) { + free(xstats); + free(xstats_names); rte_exit(EXIT_FAILURE, "rte_eth_xstats_get_names(%u) len%i failed: %d", port_id, len, ret); + } for (i = 0; i < len; i++) { if (xstats[i].value > 0) @@ -630,6 +637,9 @@ print_stats(struct stats_lcore_params *stats_lcore) continue; print_lcore_stats(stats_lcore->lconf[l_id].lcore_stats, l_id); } + + free(xstats); + free(xstats_names); } static int -- 2.20.1