From 2f59f3b085e333a7e26b6b8d2407848ff8fb35ba Mon Sep 17 00:00:00 2001 From: Fady Bader Date: Mon, 6 Jul 2020 14:32:39 +0300 Subject: [PATCH] eal: disable function versioning on Windows Function versioning implementation is not supported by Windows. Function versioning is disabled on Windows. Signed-off-by: Fady Bader Acked-by: Bruce Richardson --- doc/guides/windows_gsg/intro.rst | 4 ++++ lib/meson.build | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/guides/windows_gsg/intro.rst b/doc/guides/windows_gsg/intro.rst index a0285732df..58c6246404 100644 --- a/doc/guides/windows_gsg/intro.rst +++ b/doc/guides/windows_gsg/intro.rst @@ -18,3 +18,7 @@ DPDK for Windows is currently a work in progress. Not all DPDK source files compile. Support is being added in pieces so as to limit the overall scope of any individual patch series. The goal is to be able to run any DPDK application natively on Windows. + +The :doc:`../contributing/abi_policy` cannot be respected for Windows. +Minor ABI versions may be incompatible +because function versioning is not supported on Windows. diff --git a/lib/meson.build b/lib/meson.build index 80c37afa8f..9d69f0eb8e 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -107,6 +107,10 @@ foreach l:libraries shared_dep = declare_dependency(include_directories: includes) static_dep = shared_dep else + if is_windows and use_function_versioning + message('@0@: Function versioning is not supported by Windows.' + .format(name)) + endif if use_function_versioning cflags += '-DRTE_USE_FUNCTION_VERSIONING' @@ -138,7 +142,7 @@ foreach l:libraries include_directories: includes, dependencies: static_deps) - if not use_function_versioning + if not use_function_versioning or is_windows # use pre-build objects to build shared lib sources = [] objs += static_lib.extract_all_objects(recursive: false) -- 2.20.1