From 3057f337792ad71a65b8c5aa1f63a556837c9472 Mon Sep 17 00:00:00 2001 From: Jiawei Wang Date: Mon, 28 Jun 2021 13:58:28 +0300 Subject: [PATCH] net/mlx5: fix flow modify action validation The introduced MODIFY_FIELD action was used to manipulate the packet header field through copy or set operations. These modify header actions should be counted as one action in low level, the current code used wrong actions flags checking for modify field action. This patch update the action flags checking into the correct MODIFY_HDR_ACTIONS set. Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action") Cc: stable@dpdk.org Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 62edc4fa85..d1076655fd 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -7573,7 +7573,7 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr, if (action_flags & MLX5_FLOW_ACTION_SAMPLE) modify_after_mirror = 1; /* Count all modify-header actions as one action. */ - if (!(action_flags & MLX5_FLOW_ACTION_MODIFY_FIELD)) + if (!(action_flags & MLX5_FLOW_MODIFY_HDR_ACTIONS)) ++actions_n; action_flags |= MLX5_FLOW_ACTION_MODIFY_FIELD; rw_act_num += ret; -- 2.20.1